Skip to content

llvm-wrapper cleanup - #145092

Closed
klensy wants to merge 5 commits into
rust-lang:mainfrom
klensy:llvm-c
Closed

llvm-wrapper cleanup#145092
klensy wants to merge 5 commits into
rust-lang:mainfrom
klensy:llvm-c

Conversation

@klensy

@klensy klensy commented Aug 8, 2025 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Removes dead code and replaces few LLVMRust* with LLVM* c api, see commits with whitespace collapsed. Partially intersects with #136632.

See https://github.com/llvm/llvm-project/blob/release/19.x/llvm/lib/IR/DebugInfo.cpp

@rustbot

rustbot commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2025
@rust-log-analyzer

rust-log-analyzer commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

The job pr-check-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
  --- stdout
  cargo:rerun-if-changed=imp
  Creating /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/i686-pc-windows-gnu/release/build/proc-macro-test-d7ad627b63190638/out/proc-macro-test-imp-staging
  Creating /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/i686-pc-windows-gnu/release/build/proc-macro-test-d7ad627b63190638/out/proc-macro-test-imp-staging/src
  Copying /checkout/src/tools/rust-analyzer/crates/proc-macro-srv/proc-macro-test/imp/Cargo.toml to /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/i686-pc-windows-gnu/release/build/proc-macro-test-d7ad627b63190638/out/proc-macro-test-imp-staging/Cargo.toml
  Copying /checkout/src/tools/rust-analyzer/crates/proc-macro-srv/proc-macro-test/imp/build.rs to /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/i686-pc-windows-gnu/release/build/proc-macro-test-d7ad627b63190638/out/proc-macro-test-imp-staging/build.rs
  Copying /checkout/src/tools/rust-analyzer/crates/proc-macro-srv/proc-macro-test/imp/src/lib.rs to /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/i686-pc-windows-gnu/release/build/proc-macro-test-d7ad627b63190638/out/proc-macro-test-imp-staging/src/lib.rs
  Running cd "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/i686-pc-windows-gnu/release/build/proc-macro-test-d7ad627b63190638/out/proc-macro-test-imp-staging" && "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "-p" "proc-macro-test-impl" "--message-format" "json" "--target-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/i686-pc-windows-gnu/release/build/proc-macro-test-d7ad627b63190638/out/target" "--target" "i686-pc-windows-gnu"
  proc-macro-test-impl failed to build
  ============ stdout ============
  {"reason":"build-finished","success":false}

  ============ stderr ============
     Compiling proc-macro-test-impl v0.0.0 (/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/i686-pc-windows-gnu/release/build/proc-macro-test-d7ad627b63190638/out/proc-macro-test-imp-staging)
  rustc: /checkout/src/llvm-project/llvm/include/llvm/Support/Casting.h:578: decltype(auto) llvm::cast(From *) [To = llvm::DIType, From = llvm::Metadata]: Assertion `isa<To>(Val) && "cast<Ty>() argument of incompatible type!"' failed.
  [RUSTC-TIMING] build_script_build test:false 0.578
  rustc exited with signal: 6 (SIGABRT) (core dumped)
  error: could not compile `proc-macro-test-impl` (build script)

  Caused by:
    process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc /checkout/obj/build/bootstrap/debug/rustc --crate-name build_script_build --edition=2024 build.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type bin --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 --check-cfg 'cfg(docsrs,test)' --check-cfg 'cfg(feature, values())' -C metadata=777358d0d763388b -C extra-filename=-c96c0384969dc544 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/i686-pc-windows-gnu/release/build/proc-macro-test-d7ad627b63190638/out/target/debug/build/proc-macro-test-impl-c96c0384969dc544 -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/i686-pc-windows-gnu/release/build/proc-macro-test-d7ad627b63190638/out/target/debug/deps` (exit status: 254)


  --- stderr

  thread 'main' (30119) panicked at src/tools/rust-analyzer/crates/proc-macro-srv/proc-macro-test/build.rs:93:9:

@klensy

klensy commented Aug 8, 2025

Copy link
Copy Markdown
Contributor Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2025
@rustbot

rustbot commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@BoxyUwU

BoxyUwU commented Aug 8, 2025

Copy link
Copy Markdown
Member

r? compiler

@rustbot rustbot assigned nnethercote and unassigned BoxyUwU Aug 8, 2025
@bors

bors commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #146666) made this pull request unmergeable. Please resolve the merge conflicts.

@SpriteOvO

SpriteOvO commented Feb 13, 2026

Copy link
Copy Markdown
Member

@klensy Hi, ping from triage team. This PR has been inactive for a while. Are there any updates on this?

@JohnCSimon

JohnCSimon commented Aug 28, 2026

Copy link
Copy Markdown

Ping from triage:
@klensy
I'm closing this due to inactivity, Please reopen when you are ready to continue with this. Thank you.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Aug 28, 2026
@rustbot rustbot added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nnethercote nnethercote

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@klensy @rustbot @rust-log-analyzer @BoxyUwU @bors @SpriteOvO @JohnCSimon @nnethercote